fix(registration): prevent stored XSS in registration success message#72
Open
rishab11250 wants to merge 1 commit into
Open
fix(registration): prevent stored XSS in registration success message#72rishab11250 wants to merge 1 commit into
rishab11250 wants to merge 1 commit into
Conversation
Replace innerHTML with safe DOM methods (createTextNode + textContent) to prevent stored XSS via crafted username in the registration success flow. Also add prettier as devDependency for CI formatting compliance. Closes codepvg#57
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hello! Thank you for your first Pull Request!
We are excited to review your contribution to the CodePVG LeetCode Leaderboard.
Please make sure you have run Prettier on your code locally, as our GitHub Actions will fail if the code is unformatted. A maintainer will review your code soon. Thanks for helping out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a stored XSS vulnerability in the registration success flow. The
user-controlled
nameparameter was interpolated intoinnerHTMLwithout sanitization, allowing a crafted username to execute arbitrary
JavaScript in the victim's browser.
Fixes #57
Changes Made
frontend/registration.html:217-224— Replaceddiv.innerHTMLwithsafe DOM methods (
document.createTextNode+span.textContent) toprevent stored XSS while preserving the green-colored username display
and slide-up animation.
package.json— Addedprettieras devDependency to ensure CIformatting compliance going forward.
Type of Change
Testing
Checklist
Screenshots / Screen Recording
Visual appearance unchanged — username still displays in green with
the same slide-up animation, but now safely using textContent.